[webkit-reviews] review denied: [Bug 177185] [WPE][GTK] Add support for ICC color management : [Attachment 422825] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 177185: [WPE][GTK] Add support for ICC color management
https://bugs.webkit.org/show_bug.cgi?id=177185

Attachment 422825: Patch

https://bugs.webkit.org/attachment.cgi?id=422825&action=review




--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 422825
  --> https://bugs.webkit.org/attachment.cgi?id=422825
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422825&action=review

> Source/WebCore/platform/graphics/PlatformDisplay.cpp:278
> +{

It would be nice here to fall-back to asking colord what's the color profile
for
the screen. That would work also for Wayland-based compositors and desktop
environments which populate colord's view of the available screens (at least
GNOME Shell and Weston with the cms-colord plug-in do this).

Returning a hardwired RGB profile would be in my mind the last of resorts
after trying colord.

By the way, I think it's fine to skip adding support for colord in this patch,
but if you agree that it would be nice to consider it, let's create a new bug
to track that and maybe add a TODO/FIXME in the code ^_^

> Source/cmake/FindLCMS2.cmake:70
> +

I would rather prefer to use an imported target in this CMake find-module.
We have been transitioning towards using imported targets, for example
FindManette.cmake uses an imported target and also does the dance of
regex-matching the version from the headers as a fallback so I think it
would be a good one to use as template here :)