[webkit-reviews] review requested: [Bug 222907] [GTK] Add GTK4 tests expectations : [Attachment 422796] Initial patch

[bugzilla-daemon at webkit.org]

Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 222907: [GTK] Add GTK4 tests expectations
https://bugs.webkit.org/show_bug.cgi?id=222907

Attachment 422796: Initial patch

https://bugs.webkit.org/attachment.cgi?id=422796&action=review




--- Comment #1 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 422796

  --> https://bugs.webkit.org/attachment.cgi?id=422796&action=review

Initial patch

Initial patch. To make the usage of gtk4 platform automatic, it first checks
the contents of cmakeconfig.h, and if not present, runs an executable to check
the GTK version. This fallback will be used in the test-only bots, as they do
not download the cmakeconfig.h. It's missing the actual TestExpectation file
and a way to test the MiniBrowser fallback check in the webkitpy
unittests.\n\nIf this fallback feels too complicated, we can drop it and move
to use some envvar in the bots to pass --additional-platform-directory.