[webkit-reviews] review granted: [Bug 223011] [build.webkit.org] Update RunJavaScriptCoreTests step for new buildbot : [Attachment 422785] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 18:48:11 PST 2021


dewei_zhu at apple.com has granted Aakash Jain <aakash_jain at apple.com>'s request
for review:
Bug 223011: [build.webkit.org] Update RunJavaScriptCoreTests step for new
buildbot
https://bugs.webkit.org/show_bug.cgi?id=223011

Attachment 422785: Patch

https://bugs.webkit.org/attachment.cgi?id=422785&action=review




--- Comment #4 from dewei_zhu at apple.com ---
Comment on attachment 422785
  --> https://bugs.webkit.org/attachment.cgi?id=422785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review

>>> Tools/CISupport/build-webkit-org/steps.py:437
>>> +	     self.failedTestCount = 0
>> 
>> Is this used anywhere in this change?
> 
> It is used by the base class TestWithFailureCount (inside getResultSummary())

Why was it working before this change?	By checking the code, it looks like it
will be set by `TestWithFailureCount.commandComplete`.
Anyway, initialize an variable in the here seems no harm.


More information about the webkit-reviews mailing list