[webkit-reviews] review granted: [Bug 222713] REGRESSION (r272376): [iOS] ASSERTION FAILED: sessionID.isEphemeral() || !path.isEmpty() in WebKit::NetworkProcess::swServerForSession : [Attachment 422377] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 9 16:20:45 PST 2021
Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 222713: REGRESSION (r272376): [iOS] ASSERTION FAILED:
sessionID.isEphemeral() || !path.isEmpty() in
WebKit::NetworkProcess::swServerForSession
https://bugs.webkit.org/show_bug.cgi?id=222713
Attachment 422377: Patch
https://bugs.webkit.org/attachment.cgi?id=422377&action=review
--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 422377
--> https://bugs.webkit.org/attachment.cgi?id=422377
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422377&action=review
r=me
> Source/WebKit/NetworkProcess/NetworkProcess.cpp:432
> if (isNewEntry)
> SandboxExtension::consumePermanently(cacheRootPathHandle);
> + else
> + ASSERT_NOT_REACHED();
I would just ASSERT(isNewEntry). Then no need for if/else.
More information about the webkit-reviews
mailing list