[webkit-reviews] review granted: [Bug 222996] CRASH in MergeUVRow_AVX2 : [Attachment 422764] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 222996: CRASH in MergeUVRow_AVX2
https://bugs.webkit.org/show_bug.cgi?id=222996

Attachment 422764: Patch

https://bugs.webkit.org/attachment.cgi?id=422764&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 422764
  --> https://bugs.webkit.org/attachment.cgi?id=422764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422764&action=review

r=me

> Source/ThirdParty/libwebrtc/ChangeLog:13
> +
> +	   Crash logging shows occasional crashes in MergeUVRow_AVX2; the
explanation
> +	   for these crashes seems to be a mismatch between the size of the
libvpx
> +	   output frame and the size of the CVPixelBuffer where the converted
frame
> +	   data is being stored. Add a pre-flight check that will bail out
early in
> +	   this scenario.

At first I thought this might not be great behavior; but your comment in Radar
convinced me. Might be helpful to add that comment in your ChangeLog or in the
code.