[webkit-reviews] review granted: [Bug 222770] Adding Python type annotations to test_expectations.py : [Attachment 422313] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 222770: Adding Python type annotations to test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=222770

Attachment 422313: Patch

https://bugs.webkit.org/attachment.cgi?id=422313&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 422313
  --> https://bugs.webkit.org/attachment.cgi?id=422313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422313&action=review

>>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:47
>>> +	 from typing import (
>> 
>> How will we ever run this? Line 44 sets MYPY to false, is that overridden
when running Mypy?
> 
> MYPY automatically sets MYPY=True, so yes. What would clarify the comment?

Comment is fine, just weird that MYPY works that way. Not sure there is much to
be done, this will hopefully die soon when Python 2 does.