[webkit-reviews] review granted: [Bug 222937] Simplify CallbackAggregator in WebsiteDataStore::fetchDataAndApply() : [Attachment 422609] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 222937: Simplify CallbackAggregator in
WebsiteDataStore::fetchDataAndApply()
https://bugs.webkit.org/show_bug.cgi?id=222937

Attachment 422609: Patch

https://bugs.webkit.org/attachment.cgi?id=422609&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 422609
  --> https://bugs.webkit.org/attachment.cgi?id=422609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422609&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:432
> +private:

Should indent this 4?

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:441
> +    auto callbackAggregator = adoptRef(new CallbackAggregator(fetchOptions,
WTFMove(queue), WTFMove(apply), *this));

Seems like there is a missing * here so we get a Ref<> instead of a RefPtr<>.