[webkit-reviews] review denied: [Bug 222557] Apply transferred min/max sizes for intrinsic sizing : [Attachment 422601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 8 14:26:39 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 222557: Apply transferred min/max sizes for intrinsic sizing
https://bugs.webkit.org/show_bug.cgi?id=222557

Attachment 422601: Patch

https://bugs.webkit.org/attachment.cgi?id=422601&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 422601
  --> https://bugs.webkit.org/attachment.cgi?id=422601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422601&action=review

> Source/WebCore/rendering/RenderBlock.cpp:263
> +    bool m_hasAspectRatioPercentageHeightDescendant;

This probably introduced several bytes of padding. Is there a spare bit you can
fit this into?

These "descendant has" bits are notoriously hard to keep up-to-date accurately.
Is there a way to fix this without storing state like this?

> Source/WebCore/rendering/RenderBlock.cpp:2437
> +	  
const_cast<RenderBlock*>(this)->setHasAspectRatioPercentageHeightDescendant();

Yuck.


More information about the webkit-reviews mailing list