[webkit-reviews] review granted: [Bug 222856] REGRESSION (r273541): Payloads requiring NSURL in serialization fail : [Attachment 422473] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 8 14:11:51 PST 2021


Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 222856: REGRESSION (r273541): Payloads requiring NSURL in serialization
fail
https://bugs.webkit.org/show_bug.cgi?id=222856

Attachment 422473: Patch

https://bugs.webkit.org/attachment.cgi?id=422473&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 422473
  --> https://bugs.webkit.org/attachment.cgi?id=422473
Patch

It’s bad that there is no test. It’s non-obvious that this is required. It’s
strange that all the fields of NSURL are allocated and all the methods of NSURL
are available on this object.

But we should land this code quickly to fix the major regression and think
about those other things afterward.


More information about the webkit-reviews mailing list