[webkit-reviews] review granted: [Bug 222925] [Cocoa] Changes in WebInspectorUI's appearance don't propagate to .effectiveAppearance while docked : [Attachment 422594] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 222925: [Cocoa] Changes in WebInspectorUI's appearance don't propagate to
.effectiveAppearance while docked
https://bugs.webkit.org/show_bug.cgi?id=222925

Attachment 422594: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=422594&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 422594
  --> https://bugs.webkit.org/attachment.cgi?id=422594
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review

r=me with one question/concern

> Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862
> +    [m_inspectorViewController webView].appearance = platformAppearance;

Does this have any effect on the inspected page when Web Inspector is docked
and the developer changes the Appearance setting in the General pane of the
Settings Tab?