[webkit-reviews] review granted: [Bug 222926] [Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process : [Attachment 422595] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 222926: [Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=222926

Attachment 422595: Patch

https://bugs.webkit.org/attachment.cgi?id=422595&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 422595
  --> https://bugs.webkit.org/attachment.cgi?id=422595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422595&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:475
> +    send(Messages::GPUProcess::SetWebMParserEnabled(hasEnabledWebMParser),
0);
> +   
send(Messages::GPUProcess::SetWebMFormatReaderEnabled(hasEnabledWebMFormatReade
r), 0);
> +    send(Messages::GPUProcess::SetOpusDecoderEnabled(hasEnabledOpus), 0);
> +    send(Messages::GPUProcess::SetVorbisDecoderEnabled(hasEnabledVorbis),
0);

The messages and methods in GPUProcess.cpp/.h all have compile flags around
them, so these need to be guarded too.