[webkit-reviews] review granted: [Bug 222838] PCM: Align fraud prevention token naming with issue 73 in the Privacy CG repo : [Attachment 422447] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 222838: PCM: Align fraud prevention token naming with issue 73 in the
Privacy CG repo
https://bugs.webkit.org/show_bug.cgi?id=222838

Attachment 422447: Patch

https://bugs.webkit.org/attachment.cgi?id=422447&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 422447
  --> https://bugs.webkit.org/attachment.cgi?id=422447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422447&action=review

I think the patch works as advertised, but I'm a little confused by the source
code name changes (at least in the context of the Issue 73).

> Source/WebCore/loader/PrivateClickMeasurement.cpp:227
> +void PrivateClickMeasurement::setSourceSecretToken(SourceSecretToken&&
token)

I'm a little confused by the code renaming. If 'sign-secret-token' became
'sign-unlinkable-token', and 'get-unlinkable-token-public-key' became
'get-token-public-key' why all of this flipping of secret and unlinkable? It
seems like sourceSecretToken -> sourceUnlinkableToken makes sense, but why
didn't "setSourceUnlinkableToken' just become "setTokenPublicKey" or something?

> Source/WebCore/loader/PrivateClickMeasurement.h:298
> +    struct SourceSecretToken {

If this used to represent the unlinkable token, why isn't this now called
'SourcePublicKeyToken' or something?