[webkit-reviews] review granted: [Bug 222901] [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit style : [Attachment 422553] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 8 10:36:43 PST 2021


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 222901: [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit
style
https://bugs.webkit.org/show_bug.cgi?id=222901

Attachment 422553: Patch

https://bugs.webkit.org/attachment.cgi?id=422553&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 422553
  --> https://bugs.webkit.org/attachment.cgi?id=422553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422553&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:65
> +	   SetupFunc setupEncoder, const char* bitratePropertyName,
SetBitrateFunc setBitrate, const char* keyframeIntervalPropertyName)

SetupFunc&& and SetBitrateFunc&&


More information about the webkit-reviews mailing list