[webkit-reviews] review granted: [Bug 220861] Support aspect-ratio in intrinsic sizing : [Attachment 422528] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 8 01:38:31 PST 2021
Antti Koivisto <koivisto at iki.fi> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 220861: Support aspect-ratio in intrinsic sizing
https://bugs.webkit.org/show_bug.cgi?id=220861
Attachment 422528: Patch
https://bugs.webkit.org/attachment.cgi?id=422528&action=review
--- Comment #19 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 422528
--> https://bugs.webkit.org/attachment.cgi?id=422528
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422528&action=review
> Source/WebCore/rendering/RenderBox.h:88
> + LayoutUnit constrainLogicalWidthInFragmentByMinMax(LayoutUnit,
LayoutUnit, RenderBlock&, RenderFragmentContainer*, bool allowIntrinsic = true)
const;
Please use an enum. The 'false' in call site is mysterious.
More information about the webkit-reviews
mailing list