[webkit-reviews] review granted: [Bug 222868] Transition Cocoa DumpRenderTree to allow any preference keys, not just hard coded supported ones : [Attachment 422515] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 222868: Transition Cocoa DumpRenderTree to allow any preference keys, not
just hard coded supported ones
https://bugs.webkit.org/show_bug.cgi?id=222868

Attachment 422515: Patch

https://bugs.webkit.org/attachment.cgi?id=422515&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 422515
  --> https://bugs.webkit.org/attachment.cgi?id=422515
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422515&action=review

> Tools/DumpRenderTree/TestOptions.cpp:123
> +	       { "AspectRatioOfImgFromWidthAndHeightEnabled", false },
> +	       { "AsyncClipboardAPIEnabled", false },
> +	       { "CSSOMViewSmoothScrollingEnabled", false },
> +	       { "ContactPickerAPIEnabled", false },
> +	       { "CoreMathMLEnabled", false },
> +	       { "GenericCueAPIEnabled", false },
> +	       { "IntersectionObserverEnabled", false },
> +	       { "IsLoggedInAPIEnabled", false },
> +	       { "LazyIframeLoadingEnabled", false },
> +	       { "LazyImageLoadingEnabled", false },
> +	       { "RequestIdleCallbackEnabled", false },
> +	       { "ResizeObserverEnabled", false },
> +	       { "WebAuthenticationEnabled", false },
> +	       { "WebGPUEnabled", false },

Seems like at least some of these should just be enabled in WK1. Like,
AspectRatioOfImgFromWidthAndHeightEnabled is purely about layout.