[webkit-reviews] review granted: [Bug 222877] [perf dashboard] Use ResizeObserver in ComponentBase : [Attachment 422519] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 7 08:55:26 PST 2021


Sam Weinig <sam at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 222877: [perf dashboard] Use ResizeObserver in ComponentBase
https://bugs.webkit.org/show_bug.cgi?id=222877

Attachment 422519: Patch

https://bugs.webkit.org/attachment.cgi?id=422519&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 422519
  --> https://bugs.webkit.org/attachment.cgi?id=422519
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422519&action=review

> Websites/perf.webkit.org/ChangeLog:9
> +
> +	   Simplify the code used to schedule re-rendering of components that
dependent on its size
> +	   using ResizeObserver which has been shipping since Safari 14.

Should we remove ResizeObserver from Experimental Features at this point then?
(I filed https://bugs.webkit.org/show_bug.cgi?id=222885 to try and formalize
the rules for experimental features, but it seems like if we shipped it
already, it probably makes sense to transition away).


More information about the webkit-reviews mailing list