[webkit-reviews] review granted: [Bug 222851] [RenderTreeBuilder] Readjust the first child when it is the multicolumn container : [Attachment 422467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 20:13:43 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 222851: [RenderTreeBuilder] Readjust the first child when it is the
multicolumn container
https://bugs.webkit.org/show_bug.cgi?id=222851

Attachment 422467: Patch

https://bugs.webkit.org/attachment.cgi?id=422467&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 422467
  --> https://bugs.webkit.org/attachment.cgi?id=422467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422467&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderBlockFlow.cpp:53
> +	   beforeChild = beforeChild == multicolumnFlow ?
multicolumnFlow->firstChild() : beforeChild; 

A little hard to read. also a space at the end.


More information about the webkit-reviews mailing list