[webkit-reviews] review granted: [Bug 222463] Make server test run with new node version : [Attachment 422461] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 5 18:05:24 PST 2021
Ryosuke Niwa <rniwa at webkit.org> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 222463: Make server test run with new node version
https://bugs.webkit.org/show_bug.cgi?id=222463
Attachment 422461: Patch
https://bugs.webkit.org/attachment.cgi?id=422461&action=review
--- Comment #42 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 422461
--> https://bugs.webkit.org/attachment.cgi?id=422461
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422461&action=review
Nice! This is a lot cleaner approach.
> Websites/perf.webkit.org/tools/js/assert-override.js:3
> +function makeConsoleAssertThrow () {
Nit: no space between the function name and ().
Also { should appear on the new line.
More information about the webkit-reviews
mailing list