[webkit-reviews] review granted: [Bug 222827] [webkitscmpy] Add repository_id : [Attachment 422418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 17:20:57 PST 2021


dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 222827: [webkitscmpy] Add repository_id
https://bugs.webkit.org/show_bug.cgi?id=222827

Attachment 422418: Patch

https://bugs.webkit.org/attachment.cgi?id=422418&action=review




--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 422418
  --> https://bugs.webkit.org/attachment.cgi?id=422418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422418&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:43
> +    def __init__(self, dev_branches=None, prod_branches=None,
contributors=None, id=None):

Worth mention that id is a built-in, but seems a reasonable variable name here.


More information about the webkit-reviews mailing list