[webkit-reviews] review granted: [Bug 222798] <model> should create a model-owning compositing layer : [Attachment 422453] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 222798: <model> should create a model-owning compositing layer
https://bugs.webkit.org/show_bug.cgi?id=222798

Attachment 422453: Patch

https://bugs.webkit.org/attachment.cgi?id=422453&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 422453
  --> https://bugs.webkit.org/attachment.cgi?id=422453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422453&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:77
> +    if (auto modelData = this->modelData())
> +	   return Model::create(*modelData);

Seems weird to create one every time, but I guess for now it's just wrapping
the data.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:153
> +    WEBCORE_EXPORT void setContentsToModel(RefPtr<Model>) override;

RefPtr<Model>&&?