[webkit-reviews] review granted: [Bug 222818] [GTK] Clean up GTK-specific text checker stuff : [Attachment 422406] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 5 14:26:54 PST 2021
Don Olmstead <don.olmstead at sony.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 222818: [GTK] Clean up GTK-specific text checker stuff
https://bugs.webkit.org/show_bug.cgi?id=222818
Attachment 422406: Patch
https://bugs.webkit.org/attachment.cgi?id=422406&action=review
--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 422406
--> https://bugs.webkit.org/attachment.cgi?id=422406
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422406&action=review
> Source/WebKit/UIProcess/API/C/WKTextChecker.h:26
>
> -#ifndef WKTextChecker_h
> -#define WKTextChecker_h
> +#pragma once
Any public C API header should have the #ifndef guards.
> Source/WebKit/UIProcess/API/C/gtk/WKTextCheckerGtk.h:26
> -#ifndef WKTextCheckerGtk_h
> -#define WKTextCheckerGtk_h
> +#pragma once
Should be #ifndef guards
More information about the webkit-reviews
mailing list