[webkit-reviews] review granted: [Bug 222747] Web Inspector: border color of "grid" badge should match color of corresponding outline : [Attachment 422275] Patch

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Nikita Vasilyev <nvasilyev at apple.com>'s
request for review:
Bug 222747: Web Inspector: border color of "grid" badge should match color of
corresponding outline
https://bugs.webkit.org/show_bug.cgi?id=222747

Attachment 422275: Patch

https://bugs.webkit.org/attachment.cgi?id=422275&action=review




--- Comment #4 from BJ Burg <bburg at apple.com> ---
Comment on attachment 422275
  --> https://bugs.webkit.org/attachment.cgi?id=422275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422275&action=review

r=me with a question

> Source/WebInspectorUI/ChangeLog:18
> +	   For text and background color, only use the hue of the selected
color to keep "grid" text always readable.

Good idea.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.css:38
> +    box-shadow: 0 0 1px hsla(0, 0%, 0%, 0.5);

Is this even noticeable? I couldn't see it in the attached video.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:2063
> +	   let color =
WI.overlayManager.getGridColorForNode(this.representedObject);

Is this fallible if the DOMNode is not known by WI.overlayManager?