[webkit-reviews] review requested: [Bug 221727] [CMake] Bump cmake_minimum_required version to 3.12 or later : [Attachment 422376] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 5 09:43:24 PST 2021
Don Olmstead <don.olmstead at sony.com> has asked for review:
Bug 221727: [CMake] Bump cmake_minimum_required version to 3.12 or later
https://bugs.webkit.org/show_bug.cgi?id=221727
Attachment 422376: Patch
https://bugs.webkit.org/attachment.cgi?id=422376&action=review
--- Comment #8 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 422376
--> https://bugs.webkit.org/attachment.cgi?id=422376
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422376&action=review
> CMakeLists.txt:13
> -cmake_minimum_required(VERSION 3.10)
> +# cmake_minimum_required is also set inside
Source/${FRAMEWORK}/CMakeLists.txt
> +# in support of the AppleWin internal build so this version should be kept
in
> +# sync across those files.
> +#
> +cmake_minimum_required(VERSION 3.12)
Added a note here about that annulen
More information about the webkit-reviews
mailing list