[webkit-reviews] review denied: [Bug 221727] [CMake] Bump cmake_minimum_required version to 3.12 or later : [Attachment 422370] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 5 08:58:51 PST 2021


Konstantin Tokarev <annulen at yandex.ru> has denied  review:
Bug 221727: [CMake] Bump cmake_minimum_required version to 3.12 or later
https://bugs.webkit.org/show_bug.cgi?id=221727

Attachment 422370: Patch

https://bugs.webkit.org/attachment.cgi?id=422370&action=review




--- Comment #5 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 422370
  --> https://bugs.webkit.org/attachment.cgi?id=422370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422370&action=review

> CMakeLists.txt:9
> +cmake_minimum_required(VERSION 3.12)

cmake_minimum_required(VERSION 3.10) is also present in subprojects, such as
Source/WTF/CMakeLists.txt


More information about the webkit-reviews mailing list