[webkit-reviews] review granted: [Bug 220322] BooleanConstructor should be inlined in DFG / FTL : [Attachment 422080] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 220322: BooleanConstructor should be inlined in DFG / FTL
https://bugs.webkit.org/show_bug.cgi?id=220322

Attachment 422080: Patch

https://bugs.webkit.org/attachment.cgi?id=422080&action=review




--- Comment #10 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 422080
  --> https://bugs.webkit.org/attachment.cgi?id=422080
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422080&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:1539
> +	   m_jit.move(value.gpr(), result.gpr());
> +	   if (invert)
> +	       m_jit.xor32(TrustedImm32(1), value.gpr(), result.gpr());

Maybe,

if (invert)
    m_jit.xor32(TrustedImm32(1), value.gpr(), result.gpr());
else
    m_jit.move(value.gpr(), result.gpr());

is clearer.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:1909
>	       m_jit.move(value.gpr(), result.gpr());
> -	       m_jit.xor64(TrustedImm32(true), result.gpr());
> +	       if (invert)
> +		   m_jit.xor64(TrustedImm32(1), result.gpr());

Ditto.

if (invert)
    m_jit.xor32(TrustedImm32(1), value.gpr(), result.gpr());
else
    m_jit.move(value.gpr(), result.gpr());