[webkit-reviews] review granted: [Bug 206445] window proxy of detached iframe doesn't respect updates to global values : [Attachment 422185] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 206445: window proxy of detached iframe doesn't respect updates to global
values
https://bugs.webkit.org/show_bug.cgi?id=206445

Attachment 422185: Patch

https://bugs.webkit.org/attachment.cgi?id=422185&action=review




--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 422185
  --> https://bugs.webkit.org/attachment.cgi?id=422185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422185&action=review

r=me with nits.

> LayoutTests/fast/frames/iframe-detached-window-still-writable-eval.html:3
> +<script src="../../resources/js-test-pre.js"></script>

We just include ./../resources/js-test.js nowadays.

> LayoutTests/fast/frames/iframe-detached-window-still-writable-eval.html:5
> +    const iframe = document.createElement('iframe');

Please add a description("explanation of that this test does");

> LayoutTests/fast/frames/iframe-detached-window-still-writable-eval.html:22
> +<script src="../../resources/js-test-post.js"></script>

Not needed with my suggestion above.

> LayoutTests/fast/frames/iframe-detached-window-still-writable.html:3
> +<script src="../../resources/js-test-pre.js"></script>

no -pre

> LayoutTests/fast/frames/iframe-detached-window-still-writable.html:5
> +    const iframe = document.createElement('iframe');

Please add a description();

> LayoutTests/fast/frames/iframe-detached-window-still-writable.html:13
> +<script src="../../resources/js-test-post.js"></script>

Not needed.