[webkit-reviews] review granted: [Bug 222619] [macOS][WK2] Changing the system language does not update navigator.language : [Attachment 422116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 15:34:15 PST 2021


Per Arne Vollan <pvollan at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 222619: [macOS][WK2] Changing the system language does not update
navigator.language
https://bugs.webkit.org/show_bug.cgi?id=222619

Attachment 422116: Patch

https://bugs.webkit.org/attachment.cgi?id=422116&action=review




--- Comment #9 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 422116
  --> https://bugs.webkit.org/attachment.cgi?id=422116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422116&action=review

R=me.

> Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:121
> +    system([NSString stringWithFormat:@"defaults write NSGlobalDomain
AppleLanguages '(\"en-GB\")'"].UTF8String);

Does TestWebKitAPI need to be brought into the foreground for the preference
change to be picked up, since the preference observer in the UI process is
started when the UI process becomes foreground?


More information about the webkit-reviews mailing list