[webkit-reviews] review denied: [Bug 222620] Crash in previousSibling : [Attachment 422000] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Venky Dass
<yaranamavenkataramana at apple.com>'s request for review:
Bug 222620: Crash in previousSibling
https://bugs.webkit.org/show_bug.cgi?id=222620

Attachment 422000: Patch

https://bugs.webkit.org/attachment.cgi?id=422000&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 422000
  --> https://bugs.webkit.org/attachment.cgi?id=422000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422000&action=review

r- due to the lack of a test.

> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

Please add a test.

> Source/WebCore/editing/ApplyBlockElementCommand.cpp:294
> +	       if (previousSiblingOfText && is<Text>(*text->previousSibling())

is<Text>(*text->previousSibling()) ->
is<Text>(is<Text>(*text->previousSibling()))