[webkit-reviews] review granted: [Bug 220662] std::is_literal_type causes -Wdeprecated-declarations warning with GCC 11 : [Attachment 422138] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 13:04:52 PST 2021

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 220662: std::is_literal_type causes -Wdeprecated-declarations warning with
GCC 11

Attachment 422138: Patch


--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 422138
  --> https://bugs.webkit.org/attachment.cgi?id=422138

View in context: https://bugs.webkit.org/attachment.cgi?id=422138&action=review

>> Source/WTF/ChangeLog:6607
>> +	    use the RunLoop. Let's match them for consistency, and to delete
> The old ChangeLog here got corrupted somehow, and gedit won't allow saving
the original data.
> This is the sort of thing that's probably best fixed by pushing to SVN
directly without using webkit-patch, but I don't have an SVN account anymore.
I've just been relying on commit-queue since I left Igalia.

Seems fine to do it this way.

I don’t really understand the role of "gedit" here, but the patch seems fine.

More information about the webkit-reviews mailing list