[webkit-reviews] review granted: [Bug 222593] Adding new test conditions for WebGL should be simpler : [Attachment 422125] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 11:11:34 PST 2021

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 222593: Adding new test conditions for WebGL should be simpler

Attachment 422125: Patch


--- Comment #7 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 422125
  --> https://bugs.webkit.org/attachment.cgi?id=422125

View in context: https://bugs.webkit.org/attachment.cgi?id=422125&action=review

Thanks for the update. Still looks good to me, one small continued comment. r+

> Source/WebCore/testing/Internals.idl:104
> +    "GPUStatusFailure"

Will attempts to pass an invalid enum throw an exception? I think lowercase or
hyphenated names would be better, and more inline with web standards
conventions, because they're easier to remember.

More information about the webkit-reviews mailing list