[webkit-reviews] review granted: [Bug 222624] Fix Depth24 Stencil8 support on Simulator for Metal Angle backend : [Attachment 422007] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 10:29:27 PST 2021


Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 222624: Fix Depth24 Stencil8 support on Simulator for Metal Angle backend
https://bugs.webkit.org/show_bug.cgi?id=222624

Attachment 422007: Patch

https://bugs.webkit.org/attachment.cgi?id=422007&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 422007
  --> https://bugs.webkit.org/attachment.cgi?id=422007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422007&action=review

> Source/ThirdParty/ANGLE/ChangeLog:9
> +	Fixes the following tests:
> +	fast/canvas/webgl/context-creation-attributes.html
> +	fast/canvas/webgl/webgl-depth-texture.html 
> +	webgl/1.0.3/conformance/misc/webgl-specific.html
> +    
webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html

FYI: Seems like your editor is using tabs, which will be rejected by the commit
check.

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm
:40
> -
> +	       

Did all these spaces come from an update to the script?


More information about the webkit-reviews mailing list