[webkit-reviews] review granted: [Bug 222401] WKRemoteObjectCoder should be able to handle NSErrors from TLS failures : [Attachment 422042] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 222401: WKRemoteObjectCoder should be able to handle NSErrors from TLS
failures
https://bugs.webkit.org/show_bug.cgi?id=222401

Attachment 422042: Patch

https://bugs.webkit.org/attachment.cgi?id=422042&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 422042
  --> https://bugs.webkit.org/attachment.cgi?id=422042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422042&action=review

r=me with a couple of changes.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:237
> +    auto webView = [[[WKWebView alloc] initWithFrame:CGRectZero
configuration:[WKWebViewConfiguration
_test_configurationWithTestPlugInClassName:@"RemoteObjectRegistryPlugIn"]]
autorelease];

no autorelease] please. Just use adoptNS().

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:238
> +    auto delegate = [[TestNavigationDelegate new] autorelease];

ditto.