[webkit-reviews] review granted: [Bug 222223] Preserve information about the origin of the app highlight request : [Attachment 422026] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 3 08:38:36 PST 2021

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 222223: Preserve information about the origin of the app highlight request

Attachment 422026: Patch


--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 422026
  --> https://bugs.webkit.org/attachment.cgi?id=422026

View in context: https://bugs.webkit.org/attachment.cgi?id=422026&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlightDelegate.h:36
>  - (void)_webView:(WKWebView *)webView storeAppHighlight:(_WKAppHighlight
*)highlight inNewGroup:(BOOL)inNewGroup WK_API_AVAILABLE(macos(WK_MAC_TBA),

Since this never shipped, I wonder if we can just remove this version of the UI
delegate hook.

> Source/WebKit/WebProcess/WebPage/WebPage.h:1402
> +    WebCore::CreateNewGroupForHighlight highlightIsNewGroup() const { return
m_highlightIsNewGroup; };
> +    WebCore::HighlightRequestOriginatedInApp
highlightRequestOriginatedInApp() const { return
m_highlightRequestOriginatedInApp; };

Nit - don't need semicolons after the two inline functions here.

More information about the webkit-reviews mailing list