[webkit-reviews] review granted: [Bug 222589] WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set : [Attachment 421917] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 222589: WebKitLegacy needs to keep JSDOMWindow even though it is used while
its origin is not set
https://bugs.webkit.org/show_bug.cgi?id=222589

Attachment 421917: Patch

https://bugs.webkit.org/attachment.cgi?id=421917&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 421917
  --> https://bugs.webkit.org/attachment.cgi?id=421917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421917&action=review

r=me

> Source/WebCore/bindings/js/JSWindowProxy.cpp:109
> +	   if (!localWindow.document()->haveInitializedSecurityOrigin() &&
localWindow.document()->settings().windowObjectAlwaysInitializedWithSecurityOri
ginEnabled())

I wonder if this should include a linked on or after check -- or just be a
linked on or after check? Would be nice to avoid unnecessary divergence in web
platform behavior.