[webkit-reviews] review granted: [Bug 222605] Allow IDL `Date` to be parsed from a string in addition to a number and actual JS `Date` : [Attachment 421958] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 2 11:15:16 PST 2021
Yusuke Suzuki <ysuzuki at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 222605: Allow IDL `Date` to be parsed from a string in addition to a number
and actual JS `Date`
https://bugs.webkit.org/show_bug.cgi?id=222605
Attachment 421958: Patch
https://bugs.webkit.org/attachment.cgi?id=421958&action=review
--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 421958
--> https://bugs.webkit.org/attachment.cgi?id=421958
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=421958&action=review
r=me
> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:207
> + auto dateValue = valueToDate(lexicalGlobalObject, value);
Let's insert RETURN_IF_EXCEPTION(scope, { });.
More information about the webkit-reviews
mailing list