[webkit-reviews] review granted: [Bug 222582] REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS : [Attachment 421905] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 2 05:27:27 PST 2021


Per Arne Vollan <pvollan at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 222582: REGRESSION(r270691): It's impossible to use MobileAsset fonts on
macOS
https://bugs.webkit.org/show_bug.cgi?id=222582

Attachment 421905: Patch

https://bugs.webkit.org/attachment.cgi?id=421905&action=review




--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 421905
  --> https://bugs.webkit.org/attachment.cgi?id=421905
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421905&action=review

Thanks! R=me.

> Source/WebKit/UIProcess/WebPageProxy.cpp:10413
> +   
SandboxExtension::createHandleForMachLookup("com.apple.mobileassetd.v2"_s,
WTF::nullopt, mobileAssetHandleV2);

Perhaps a new HAVE define could be added to protect this?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1103
> +	   "com.apple.mobileassetd.v2"

Is adding this needed when __MAC_OS_X_VERSION_MIN_REQUIRED <= 110000? We should
do our best to avoid adding access to new services, also for older OSes.


More information about the webkit-reviews mailing list