[webkit-reviews] review granted: [Bug 222552] Make the data backing generated global AtomString values accessible : [Attachment 421826] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 222552: Make the data backing generated global AtomString values accessible
https://bugs.webkit.org/show_bug.cgi?id=222552

Attachment 421826: Patch

https://bugs.webkit.org/attachment.cgi?id=421826&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 421826
  --> https://bugs.webkit.org/attachment.cgi?id=421826
Patch

Is this going to make the binary bigger?

Is the name with the "Data" suffix good enough to use outside the file? The
choice of the name was "low stakes" since it was used only within the generated
code. Now that it’s visible for use elsewhere in WebKit the name could matter a
little more.