[webkit-reviews] review granted: [Bug 222555] Use PriorityQueue in NetworkCache::Storage : [Attachment 421840] patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 222555: Use PriorityQueue in NetworkCache::Storage
https://bugs.webkit.org/show_bug.cgi?id=222555

Attachment 421840: patch

https://bugs.webkit.org/attachment.cgi?id=421840&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 421840
  --> https://bugs.webkit.org/attachment.cgi?id=421840
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421840&action=review

r=me

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:61
> +    static uint64_t ordinal;

I had to look up ordinal in a dictionary but it holds up :)

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:187
> +    PriorityQueue<std::unique_ptr<ReadOperation>, &isHigherPriority>
m_pendingReadOperations;

We may be able to use UniqueRef instead of unique_ptr?