[webkit-reviews] review granted: [Bug 225616] [webkitscmpy] Cache identifiers in Git checkouts : [Attachment 432528] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 30 15:19:02 PDT 2021


dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 225616: [webkitscmpy] Cache identifiers in Git checkouts
https://bugs.webkit.org/show_bug.cgi?id=225616

Attachment 432528: Patch

https://bugs.webkit.org/attachment.cgi?id=432528&action=review




--- Comment #12 from dewei_zhu at apple.com ---
Comment on attachment 432528
  --> https://bugs.webkit.org/attachment.cgi?id=432528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432528&action=review

r=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:51
> +	       if os.path.exists(self.path):

Maybe we can do
``
if not os.path.exists(self.path):
    return
``
to avoid indentation.


More information about the webkit-reviews mailing list