[webkit-reviews] review granted: [Bug 227171] Add a new pattern to instruction selector to use EXTR supported by ARM64 : [Attachment 432613] Patch

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227171: Add a new pattern to instruction selector to use EXTR supported by
ARM64
https://bugs.webkit.org/show_bug.cgi?id=227171

Attachment 432613: Patch

https://bugs.webkit.org/attachment.cgi?id=432613&action=review




--- Comment #15 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 432613
  --> https://bugs.webkit.org/attachment.cgi?id=432613
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432613&action=review

r=me with a minor comment.
Thank you for the explanation about sbfiz, I had missed that it uses SShr
instead of ZShr.
I'll cq+ once all the bots are green (unless you can/want to do it yourself).

> Source/JavaScriptCore/b3/B3ReduceStrength.cpp:1491
> +			   replaceWithIdentity(m_value->child(0)->child(0));

I don't think this is needed: in the case where amount1 == 0,the shifts will
already be replaced by Identity in handleShiftAmount().