[webkit-reviews] review denied: [Bug 227530] [Model] [macOS] Add support for rendering model resources : [Attachment 432599] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227530: [Model] [macOS] Add support for rendering model resources
https://bugs.webkit.org/show_bug.cgi?id=227530

Attachment 432599: Patch

https://bugs.webkit.org/attachment.cgi?id=432599&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 432599
  --> https://bugs.webkit.org/attachment.cgi?id=432599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432599&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.mm:29
> +#if ENABLE(MODEL_ELEMENT)

We shouldn't use .mm for cross platform code like this. Please keep this a .cpp
file and factor out the objective-c bits into their own classes.