[webkit-reviews] review granted: [Bug 227443] [Model] [iOS] Add support for displaying <model> in fullscreen : [Attachment 432577] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 30 09:21:23 PDT 2021

Sam Weinig <sam at webkit.org> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227443: [Model] [iOS] Add support for displaying <model> in fullscreen

Attachment 432577: Patch


--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 432577
  --> https://bugs.webkit.org/attachment.cgi?id=432577

View in context: https://bugs.webkit.org/attachment.cgi?id=432577&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.h:54
> +    RenderModel* renderer() const;

I don't particularly like this idiom, where this is implemented in
RenderModel.h. That is just really hard to find. Is it needed?

> Source/WebCore/rendering/RenderModel.h:57
> +    return downcast<RenderModel>(HTMLElement::renderer());

What happens if a <model> has a different kind of renderer? like via
-webkit-appearance or something like that?

More information about the webkit-reviews mailing list