[webkit-reviews] review granted: [Bug 227226] BabylonJS Under water demo is slower than it should be on Intel : [Attachment 432563] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 21:09:08 PDT 2021

Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 227226: BabylonJS Under water demo is slower than it should be on Intel

Attachment 432563: Patch


--- Comment #7 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 432563
  --> https://bugs.webkit.org/attachment.cgi?id=432563

View in context: https://bugs.webkit.org/attachment.cgi?id=432563&action=review

Looks good to me. A few minor comments about the commit message. r+

> Source/ThirdParty/ANGLE/ChangeLog:7
> +	   Removing fastmath in all scenarios leads to unnacceptable
performance on integrated graphics

Consider adding periods at end of sentences.

> Source/ThirdParty/ANGLE/ChangeLog:8
> +	   Currently, webgl conformance tests and the safrai tests don't have
any invariance tests that show issue. 

safrai -> safari

show issue -> "show issues" or "show the issue"

More information about the webkit-reviews mailing list