[webkit-reviews] review granted: [Bug 227279] Add ID and versioning support for AppHighlights : [Attachment 432547] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 17:11:18 PDT 2021


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227279: Add ID and versioning support for AppHighlights
https://bugs.webkit.org/show_bug.cgi?id=227279

Attachment 432547: Patch

https://bugs.webkit.org/attachment.cgi?id=432547&action=review




--- Comment #17 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432547
  --> https://bugs.webkit.org/attachment.cgi?id=432547
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432547&action=review

> Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp:96
> +    static_assert(!Encoder::isIPCEncoder, "AppHighlightRangeData should not
be used by WTF::IPC::Encoder");

Drop the WTF:: (IPC::Encoder is not in WTF namespace).


More information about the webkit-reviews mailing list