[webkit-reviews] review granted: [Bug 227482] ASSERT in webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-variables.html IdGen ASSERT(*base != '_'); : [Attachment 432471] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 15:46:35 PDT 2021


Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 227482: ASSERT in 
webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-variables.html  
IdGen ASSERT(*base != '_');
https://bugs.webkit.org/show_bug.cgi?id=227482

Attachment 432471: Patch

https://bugs.webkit.org/attachment.cgi?id=432471&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 432471
  --> https://bugs.webkit.org/attachment.cgi?id=432471
Patch

OK since this is tested, but: please keep in mind that in the WebGL shading
language spec certain prefixes are reserved. See
https://www.khronos.org/registry/webgl/specs/latest/1.0/#4.3 . Plausibly, if
the shader compiler was instantiated for a WebGL context, it should be using
"_webgl" as the prefix for all of these internally-generated names.

r+


More information about the webkit-reviews mailing list