[webkit-reviews] review granted: [Bug 227448] [Model] [iOS] Add support for manipulating <model> inline : [Attachment 432478] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 29 14:38:25 PDT 2021
Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227448: [Model] [iOS] Add support for manipulating <model> inline
https://bugs.webkit.org/show_bug.cgi?id=227448
Attachment 432478: Patch
https://bugs.webkit.org/attachment.cgi?id=432478&action=review
--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432478
--> https://bugs.webkit.org/attachment.cgi?id=432478
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432478&action=review
> Source/WebKit/UIProcess/ios/WKModelInteractionGestureRecognizer.mm:38
> +- (void)touchesBegan:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
Likely you could avoid the GR and just use the UIResponder versions of these
(on WKModelView directly), but this is also perfectly fine.
More information about the webkit-reviews
mailing list