[webkit-reviews] review granted: [Bug 226172] Implement form[method=dialog] : [Attachment 432507] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 226172: Implement form[method=dialog]
https://bugs.webkit.org/show_bug.cgi?id=226172

Attachment 432507: Patch

https://bugs.webkit.org/attachment.cgi?id=432507&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 432507
  --> https://bugs.webkit.org/attachment.cgi?id=432507
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432507&action=review

> Source/WebCore/html/HTMLFormElement.cpp:421
> +    RefPtr<HTMLDialogElement> dialog =
ancestorsOfType<HTMLDialogElement>(*this).first();

nit: RefPtr<HTMLDialogElement> -> RefPtr (with C++17, the compiler should be
able to deduce the type).