[webkit-reviews] review granted: [Bug 226172] Implement form[method=dialog] : [Attachment 432506] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 226172: Implement form[method=dialog]
https://bugs.webkit.org/show_bug.cgi?id=226172

Attachment 432506: Patch

https://bugs.webkit.org/attachment.cgi?id=432506&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 432506
  --> https://bugs.webkit.org/attachment.cgi?id=432506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432506&action=review

r=me with changes.

> Source/WebCore/html/HTMLFormElement.cpp:421
> +    RefPtr<HTMLDialogElement> dialog =
ancestorsOfType<HTMLDialogElement>(*this).first();

RefPtr<HTMLDialogElement> -> RefPtr

> Source/WebCore/html/ImageInputType.cpp:220
> +    return String::number(m_clickLocation.x()) + "," +
String::number(m_clickLocation.y());

As mentioned earlier, this is inefficient and should be using makeString(), NOT
String::number().