[webkit-reviews] review denied: [Bug 227258] [Gstreamer] timeouts in media/media-source/media-source-has-audio-video.html and media/media-source/media-source-seek-unbuffered.html : [Attachment 432398] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 03:10:15 PDT 2021


Alicia Boya García <aboya at igalia.com> has denied Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 227258: [Gstreamer] timeouts in
media/media-source/media-source-has-audio-video.html and
media/media-source/media-source-seek-unbuffered.html
https://bugs.webkit.org/show_bug.cgi?id=227258

Attachment 432398: Patch

https://bugs.webkit.org/attachment.cgi?id=432398&action=review




--- Comment #11 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 432398
  --> https://bugs.webkit.org/attachment.cgi?id=432398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432398&action=review

>> LayoutTests/media/media-source/media-source-seek-unbuffered.html:47
>> +	    var interval = setInterval(function checkNotUpdating() {
> 
> I must find a different way to append the second media segment, since this
way isn't working on the mac-wk2-stress.

Listen for the "updateend" event. When it's fired, it's safe to append another
segment.


More information about the webkit-reviews mailing list