[webkit-reviews] review granted: [Bug 227202] Add ARM64 BIC, ORN, FBXIL to AIR opcode and select them in AIR : [Attachment 432447] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227202: Add ARM64 BIC, ORN, FBXIL to AIR opcode and select them in AIR
https://bugs.webkit.org/show_bug.cgi?id=227202

Attachment 432447: Patch

https://bugs.webkit.org/attachment.cgi?id=432447&action=review




--- Comment #15 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 432447
  --> https://bugs.webkit.org/attachment.cgi?id=432447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432447&action=review

Nice work.

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2916
> +		   auto isValidMask2 = [&] () -> bool {

I like your style of lambda usage. It makes the code easy to read since you are
naming this block of computation.